Canon size mode (Scaling Pokemon sizes based on their listed dex height)#6
Open
Nurufu wants to merge 19 commits into40Cakes:mainfrom
Open
Canon size mode (Scaling Pokemon sizes based on their listed dex height)#6Nurufu wants to merge 19 commits into40Cakes:mainfrom
Nurufu wants to merge 19 commits into40Cakes:mainfrom
Conversation
…at always included a fakemon in pokemon list
…aller ones stay on the ground while canon heights on used
…k to reduce transform scale from 1.6x to 1.2x. Added check to remove img max-width. Added comments for new heights related code additions.
Merge Canon sizing into main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added logic to resize the height of every Pokemon gif to be 1cm=1px tall. All of the math and newly resized heights can be found Here. Many Pokemon received manual height adjustments as well, either due to dex height being their wingspan for a lot of the birds or their length for serpent-like mons. Additionally, due to Gmax mons being absolutely massive, I've included 2 versions of the size multiplier list to make it a bit more usable.
Swapping between the size lists can be achieved by switching between these two scripts on line 15 of the
background.htmlfile:<script src="scripts/background_pokemon-size-reasonable-gmax.js"> </script><script src="scripts/background_pokemon-size-silly-gmax.js"> </script>I view this more as a novelty/fun kind of option than something actually practical. If you ever wanted to absolutely ruin bingo, this would be the way to do it.
Unlike the spheal PR I made instead of making this using the Wallpaper Engine version's codebase and then porting it back to the original (Which is how the css animations didn't get included... sorry about that) I built this on the original codebase instead. I've also been extensively testing and tweaking values and haven't had any issues both running it in browser or through OBS so fingers crossed nothing is broken this time.